Monitor Reply

Support

Undefined array key 1

Permalink Browser Info Environment March 01, 2023 at 12:32 PM

Hi

Just starting to use v9 of Concrete and PHP 8.
Get the attached error, seems to be related to adding a select field.

Any ideas how to avoid it?
Thanks
Dave

1 Attachment

Type:	Ticket
Status:	In Progress

ramonleenders replied on Mar 1, 2023 at 12:45 pm Permalink Reply

Hi Dave,

Did you use the double semicolon in your input?

concrete5_old :: Concrete5 CMS 5.6
concrete5_legacy :: Concrete5 CMS 5.7
concretecms :: ConcreteCMS 9.0
wordpress :: WordPress

If not, these are needed to have a key/value pair. So everything at the start will be your key, behind will be the value.

Kind regards
Ramon

madesimplemedia replied on Mar 1, 2023 at 1:02 pm Permalink Reply

Hi Ramon

Thanks, I hadn't done that so I have now done that and successfully created the test block.

However, when I add it to the page I get this:

Undefined variable $slct

Details

/home/templatev9/public_html/application/blocks/test_block/form.php(6): Whoops\Exception\ErrorException->null
/home/templatev9/public_html/application/blocks/test_block/form.php(6): Whoops\Run->handleError
/home/templatev9/public_html/concrete/src/Block/View/BlockView.php(380): null->include
/home/templatev9/public_html/application/blocks/test_block/add.php(2): Concrete\Core\Block\View\BlockView->inc
/home/templatev9/public_html/concrete/src/Block/View/BlockView.php(267): null->include
/home/templatev9/public_html/concrete/src/View/AbstractView.php(164): Concrete\Core\Block\View\BlockView->renderViewContents
...

madesimplemedia replied on Mar 1, 2023 at 1:04 pm Permalink Reply

Ah this seems to be a PHP 8 thing. Have you got it working on 8 yet, if not I'll stick to 7?

ramonleenders replied on Mar 1, 2023 at 1:06 pm Permalink Reply

Hey Dave,

Looks like somewhere the generated code messed up. Can you take a look in your generated view file?

$slct

This variable seems not to exist, but it should if you named it like this? Not sure what happened there...

Kind regards
Ramon

madesimplemedia replied on Mar 1, 2023 at 1:38 pm Permalink Reply

Here you go, works in PHP7.4:

<?php defined("C5_EXECUTE") or die("Access Denied."); ?>
<?php if (trim($slct) != "") { ?>

<?php switch($slct) {
case "yes":
// ENTER MARKUP HERE FOR FIELD "Select" : CHOICE "Yes"
break;
case "no":
// ENTER MARKUP HERE FOR FIELD "Select" : CHOICE "No"
break;
case "not_sure":
// ENTER MARKUP HERE FOR FIELD "Select" : CHOICE "Not Sure"
break;
} ?><?php } ?>
<?php if (!empty($lnk) && ($lnk_c = Page::getByID($lnk)) && !$lnk_c->error && !$lnk_c->isInTrash()) {
?>
<?php echo '<a href="' . $lnk_c->getCollectionLink() . '">' . (isset($lnk_text) && trim($lnk_text) != "" ? $lnk_text : $lnk_c->getCollectionName()) . '</a>';
?><?php } ?>
<?php if ($img) { ?>
<img src="<?php echo $img->getURL(); ?>" alt="<?php echo $img->getTitle(); ?>"/><?php } ?>
<?php if (isset($fle) && $fle !== false) { ?>
<a href="<?php echo $fle->urls["relative"]; ?>">
<?php echo isset($fle_title) && trim($fle_title) != "" ? h($fle_title) : $fle->getTitle(); ?>
</a><?php } ?>
<?php if (isset($txtar) && trim($txtar) != "") { ?>
<?php echo h($txtar); ?><?php } ?>
<?php if (isset($txtbx) && trim($txtbx) != "") { ?>
<?php echo h($txtbx); ?><?php } ?>

ramonleenders replied on Mar 1, 2023 at 1:48 pm Permalink Reply

What happens if you change

<?php if (trim($slct) != "") { ?>

To

<?php if (isset($slct) && trim($slct) != "") { ?>

And

<?php if ($img) { ?>

To

<?php if (isset($img) && $img) { ?>

Does that give you an error elsewhere or does it work directly?

Kind regards
Ramon

madesimplemedia replied on Mar 1, 2023 at 1:55 pm Permalink Reply

Same issue, it seems the issue is in form.php, doesn't like $slct:

<?php echo $form->select($view->field('slct'), $slct_options, $slct, []); ?>

ramonleenders replied on Mar 1, 2023 at 1:57 pm Permalink Reply

OK, stick with PHP7 for now then. I will have to dive deeper at some point in time when I have the time to do so! Probably it is the same in the form.php file where it needs an "isset($slct)" as well..

Kind regards
Ramon

madesimplemedia replied on Mar 1, 2023 at 1:58 pm Permalink Reply

OK thanks Ramon

kspitzley replied on Mar 27, 2023 at 2:59 pm Permalink Reply

I'm also having this issue! I'll downgrade to 7 for now and see if it helps too.

kspitzley replied on Mar 27, 2023 at 3:06 pm Permalink Reply

Actually I take it back - I was having trouble creating the block because I thought setting the array key values was optional, but when i do set them, I am able to add my block to a page just fine. I'm running Concrete v9.3.1 on PHP 8.1

Block Designer

Support

Undefined array key 1

Issue Reply

concrete5 Environment Information

Browser User-Agent String

Hide Post Content

Request Refund

Code

Delete Post