Installation error on PHP 7.2.2

Permalink Browser Info Environment
Hi mnakalay.

I salute your initiative to make this free add-on and I want to thank you for this.
That being said, I wanted to install your add-on and see what it can do but I received this error on installation:

Use of undefined constant ELEMENTAL_CLONER_PACKAGE_HANDLE - assumed 'ELEMENTAL_CLONER_PACKAGE_HANDLE' (this will throw an Error in a future version of PHP)

I presume this is because I use XAMPP with PHP 7.2.2.
Is there any way to eliminate this error without changing PHP version while keeping the compatibility with older PHP versions?

Thanks.

Type: Discussion
Status: Resolved
cristi78
View Replies:
mnakalay replied on at Permalink Reply
mnakalay
Thank you for bringing that to my attention. I'm on it and will have a fix shortly
mnakalay replied on at Permalink Reply
mnakalay
Hello again, problem solved, you can update to 1.0.1 and install it normally now.

If you had time to leave a review that would be great. Free projects especially can use all the love they can get ;-)
cristi78 replied on at Permalink Reply 1 Attachment
cristi78
With pleasure but for some reason I can't do it right now.
I'm logged in on C5 site but on reviews page there is no new post/review button (see screenshot)
Same issue on Chrome and Edge.

Thanks.
mnakalay replied on at Permalink Reply
mnakalay
Yeah, that system is a bit of a pain. If you get the package using the "download archive" link you don't have access to reviews. You have to add it to your cart and get through the process to get a license before you can see those buttons.

I have sent you a license myself so you don't need to go through the hassle. I think you should be able to see those buttons now.

And many thanks in advance for your review.
mnakalay replied on at Permalink Reply
mnakalay
Thank you for your review.

As an FYI I am thinking of adding the option to put the theme in a package. Probably in a few weeks
cristi78 replied on at Permalink Reply
cristi78
This will be really great :)
mnakalay replied on at Permalink Reply
mnakalay
Hey there. Just as an FYI, the new version 1.2.0 allows you to package your theme :)
cristi78 replied on at Permalink Reply
cristi78
I gave it a try and there is a little problem if I use the same image for the package's icon as for the theme's thumbnail.

File not found at path: application/files/tmp/elementalcloner/image.jpg

It seems that after creating the theme, just before creating the package, the image is deleted from application/files/tmp/elementalcloner.

If I use different files (image1.jpg for thumbnail and image2,jpg for icon) is working perfectly.

I don't see it as a bug but maybe you should put a warning to not use the same image...
Or check if both settings point to the same image file and delete it at the end of the process.

Everything else is working as expected. Made a clone package on a test instance and installed it on another one successfully.

Great job!

Thanks.
mnakalay replied on at Permalink Reply
mnakalay
Oh yes, that makes total sense I see why it's happening.

No need for a warning I'll have it fixed today. Thank you for bringing it up to my attention
mnakalay replied on at Permalink Reply
mnakalay
Version 1.2.2 available and everything should be ok now.

As an FYI what was happening is during the final cleanup operation (deleting uploaded images from the server) it was throwing an error trying to delete the same file a second time. The package and theme were still created correctly since the cleanup takes place at the end after everything else.

Now it checks for the file before trying to delete it.

Thanks again
cristi78 replied on at Permalink Reply
cristi78
Another properly working add-on ;)

Thanks.
mnakalay replied on at Permalink Reply
mnakalay
Thank you!

concrete5 Environment Information

XAMPP (PHP 7.2.2)
Concrete5 8.4.1

Browser User-Agent String

Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.75 Safari/537.36

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You have not specified a license for this support ticket. You must have a valid license assigned to a support ticket to request a refund.