view.php bug for PHP72 error OR No Result Text may not be working for a while

Permalink Browser Info Environment
Line 140 of
/skybluesofa_page_list_plus/blocks/page_list_plus/view.php

You need to change from

<?php if (count($pages) == 0): ?>

to
<?php if (count($controller->pages) == 0): ?>


Otherwise you get the following error on PHP7.2 which you can now only use count() for array.

Exception Occurred: /var/www/html/packages/skybluesofa_page_list_plus/blocks/page_list_plus/view.php:140 count(): Parameter must be an array or an object that implements Countable (2)



I think No Result Text function was not working for a while.

Type: Discussion
Status: In Progress
concrete5cojp
View Replies:
katz515 replied on at Permalink Reply
katz515
That was me.
Sorry I posted from the company account.
katz515 replied on at Permalink Reply
katz515
Oh don't also forget custom template /skybluesofa_page_list_plus/blocks/page_list_plus/templates/thumbnail_grid/view.php
janwidmer replied on at Permalink Reply
janwidmer
any chance that we get a fix for that soon? I also bought your plugin and have this bug..

concrete5 Environment Information

PHP 7.2.9

Browser User-Agent String

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You may not request a refund that is not currently owned by you.