Suggestion for jQuery- use outerHeight
Permalink Browser Info Environment
Hi,
All in all a great plugin- just leaving a small suggestion for the package's javascript. I would change lines 47 through 49 to the following as images with borders, (or background images + padding to make borders) are clipped by the current code.
All in all a great plugin- just leaving a small suggestion for the package's javascript. I would change lines 47 through 49 to the following as images with borders, (or background images + padding to make borders) are clipped by the current code.
if (imgHeight == null) {imgHeight = $(".formigo-slider-item-image-left-image > img").outerHeight()}; if (imgHeight == null) {imgHeight = $(".formigo-slider-item-image-right-image > img").outerHeight()}; if (imgHeight == null) {imgHeight = $(".formigo-slider-item-full-image > img").outerHeight()};
Type: | Discussion |
---|---|
Status: | New |
Best
Ollie