2 Bugs with PHP 7.2 and Concrete 8.4.3

Permalink Browser Info Environment
Hey there,
I bought your plugin and am using it on my website with PHP 7.2 and Concrete 8.4.3.

As soon as I place the page list plus on the page, I get two errors.

It seems, that the following things need to be fixed:

// replace in view.php | templates/thumbnail_grid/view.php
<?php if (count($pages) == 0): ?>
// by
<?php if (count($controller->pages) == 0): ?>


// replace in controller.php
$collectionAttributeKey = new CollectionAttributeKey();
$columns = $db->MetaColumns($collectionAttributeKey->getIndexedSearchTable());
// by 
use \Concrete\Core\Attribute\Key\Category as Category;
$category = Category::getByHandle('collection')->getController();
$columns = $db->MetaColumnNames($category->getIndexedSearchTable());


The second issue and it's solution was also described in a git ticket:https://github.com/concrete5/concrete5/issues/4916...

Type: Ticket
Status: New
janwidmer
View Replies:

concrete5 Environment Information

# concrete5 Version
Core Version - 8.4.3
Version Installed - 8.4.3
Database Version - 20180716000000

# concrete5 Packages
Block Designer (3.2.0), Block Designer Pro (3.0.0), Fileset Attribute (1.1), JW Events (1.0.0), JW Gallery (1.13), JW News (1.0.2), Migration Tool (0.9.0), Page List+ (2.0.1.3), Page Selector Attribute (2.0), ThemeTsv (1.00)

# concrete5 Overrides
None

# concrete5 Cache Settings
Block Cache - On
Overrides Cache - Off
Full Page Caching - Off
Full Page Cache Lifetime - Every 6 hours (default setting).

# Server Software
Apache/2.4

# Server API
cgi-fcgi

# PHP Version
7.2.11

# PHP Extensions
apcu, bcmath, bz2, calendar, cgi-fcgi, Core, ctype, curl, date, dba, dom, exif, fileinfo, filter, ftp, gd, geoip, gettext, gmp, gnupg, hash, iconv, imagick, imap, intl, jsmin, json, ldap, libxml, mailparse, mbstring, mcrypt, mongodb, mysqli, mysqlnd, odbc, openssl, pcntl, pcre, PDFlib, PDO, pdo_dblib, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, pspell, readline, recode, Reflection, scrypt, session, SimpleXML, snmp, soap, sockets, SPL, sqlite3, ssh2, standard, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, wddx, xml, xmlreader, xmlrpc, xmlwriter, xsl, yaml, Zend OPcache, zip, zlib

# PHP Settings
max_execution_time - 30
log_errors_max_len - 1024
max_file_uploads - 20
max_input_nesting_level - 64
max_input_time - 60
max_input_vars - 1000
memory_limit - 128M
post_max_size - 16M
upload_max_filesize - 16M
ldap.max_links - Unlimited
mysqli.max_links - Unlimited
mysqli.max_persistent - Unlimited
odbc.max_links - Unlimited
odbc.max_persistent - Unlimited
pcre.backtrack_limit - 1000000
pcre.recursion_limit - 100000
pgsql.max_links - Unlimited
pgsql.max_persistent - Unlimited
session.cache_limiter - <i>no value</i>
session.gc_maxlifetime - 7200
soap.wsdl_cache_limit - 5
opcache.max_accelerated_files - 4000
opcache.max_file_size - 0
opcache.max_wasted_percentage - 5

Browser User-Agent String

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36

Hide Post Content

This will replace the post content with the message: "Content has been removed by an Administrator"

Hide Content

Request Refund

You may not request a refund that is not currently owned by you.